feat: Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #248

Manav-Aggarwal · 2022-08-03T07:40:24Z

Description

As part of the fraudproof cycle described in #245, we'd like to be able to test stateless execution for a cosmos-sdk baseapp by using fraudproofs based on the new multistore with SMTs.

Parts covered from the cycle of a fraudproof:

Optimint Full Node (Producer of fraudproof)
3. The cosmos-sdk will simply execute the fraudulent block while logging all the states touched by the transaction. This minimial snapshot will be packaged as a fraudproof and passed back to optimint.

Optimint Full/Light Node (Verifier of fraudproof)
3. Now, it spins up a fresh cosmos-sdk and tells it to initialize with the fraudproof which is essentially a minimal snapshot sufficient to execute the fraudulent block.

Closes: #252

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

[] confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

liamsi · 2022-08-05T02:57:33Z

db/types/creator.go

-	// RocksDBBackend represents rocksdb (uses github.com/cosmos/gorocksdb)
-	//   - EXPERIMENTAL
-	//   - requires gcc
-	//   - use rocksdb build tag (go build -tags rocksdb)
-	RocksDBBackend BackendType = "rocksdb"


Q: What is the reason for removing rocksdb here?

011f9d1
Had local issues with dependency management in macOS so added it, apologies, will revert this before merging (adding note in description)

liamsi · 2022-08-05T03:02:56Z

store/v2alpha1/smt/store.go

+func (s *Store) GetSMTProof(key []byte) (*smt.SparseMerkleProof, error) {
+	if len(key) == 0 {
+		return nil, errKeyEmpty
+	}
+	proof, err := s.tree.Prove(key)
+	if err != nil {
+		return nil, err
+	}
+	return &proof, nil
+}


What is wrong with above's GetProof?

The smt library accepts a raw proof only in the construction of deepSubTrees which are used when verifying a fraudProof before loading up a baseApp with it

Hmm but this is about reading proofs, not writing proofs, no? Why does the SMT accepting raw proofs as writes matter?

baseapp/baseapp_test.go

liamsi · 2022-08-05T03:14:22Z

store/v2alpha1/multi/params.go

+		traceListenMixin:          newTraceListenMixin(),
+		substoreTraceListenMixins: make(map[types.StoreKey]*traceListenMixin),


With the substoreTraceListenMixins, the traceListenMixin seems a bit redundant. Or is it still required?

I view traceListenMixin as a tracer for Multistore and the substoreTraceListenMixins as tracers for each individual subStore

Ah OK. We can later make this a bit more explicit by renaming the variables or at least adding comments. Once the PR is feature complete.

liamsi

Can't wait to see a simple single-round fraud proof in action!

baseapp/fraudproof.go

baseapp/options.go

baseapp/baseapp_test.go

store/tracekv/store.go

store/v2alpha1/smt/store.go

adlerjohn · 2022-08-07T17:06:37Z

baseapp/baseapp_test.go

+	storeKeyToSubstoreTraceBuf := make(map[stypes.StoreKey]*bytes.Buffer)
+	storeKeyToSubstoreTraceBuf[capKey2] = subStoreTraceBuf
+
+	fraudProof := generateFraudProof(cms, storeKeyToSubstoreTraceBuf)


Can you clarify a bit the order of operations to get to here? Does appB1.Commit() above commit state changes to disk? Does generateFraudProof get Merkle proofs against the post-execution root, or the pre-execution root?

Calls to Commit() are irrelevant here, so I removed them for clarity. app.cms is able to access any state modified by block transactions.

generateFraudProof gets Merkle proofs against the post-execution root. We'd like the pre-execution root which is where rolling back the app's state to the previous block is needed.

baseapp/baseapp_test.go

…n revert back when merging" This reverts commit 011f9d1.

Manav-Aggarwal · 2022-11-07T18:28:28Z

everything is moved to cosmos-sdk-rollmint repo

Manav-Aggarwal added C: Cevmos Changes related to the cevmos branches block-fraud-proofs Block Fraud Proofs (Generation and verification) labels Aug 3, 2022

Manav-Aggarwal self-assigned this Aug 3, 2022

Manav-Aggarwal linked an issue Aug 3, 2022 that may be closed by this pull request

Implement a Single Round Fraudproof as a minimal integration test #245

Closed

5 tasks

Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from 16b2d33 to 4e7e590 Compare August 3, 2022 16:29

Manav-Aggarwal requested a review from jbowen93 August 3, 2022 18:07

github-actions bot added C:Store C:orm labels Aug 4, 2022

Manav-Aggarwal requested a review from liamsi August 5, 2022 02:56

liamsi reviewed Aug 5, 2022

View reviewed changes

liamsi requested a review from adlerjohn August 5, 2022 03:14

liamsi reviewed Aug 5, 2022

View reviewed changes

liamsi requested review from adlerjohn and removed request for adlerjohn August 5, 2022 14:09

Manav-Aggarwal requested a review from tzdybal August 5, 2022 16:16

Manav-Aggarwal marked this pull request as ready for review August 5, 2022 17:58

Manav-Aggarwal changed the title ~~Implement a Single Round Fraudproof as a minimal integration test~~ feat: Implement a Single Round Fraudproof as a minimal integration test Aug 5, 2022

Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from 6c54c75 to 1c95f17 Compare August 6, 2022 04:32

github-actions bot removed the C:orm label Aug 6, 2022

adlerjohn reviewed Aug 6, 2022

View reviewed changes

Manav-Aggarwal requested a review from adlerjohn August 6, 2022 07:02

Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from c80d9ea to 1702a47 Compare August 6, 2022 17:39

Manav-Aggarwal mentioned this pull request Aug 6, 2022

feat: Implement fraudproof generation mode in cosmos-sdk #250

Closed

18 tasks

adlerjohn reviewed Aug 7, 2022

View reviewed changes

store/v2alpha1/smt/store.go Outdated Show resolved Hide resolved

store/v2alpha1/smt/store.go Show resolved Hide resolved

adlerjohn reviewed Aug 7, 2022

View reviewed changes

Manav-Aggarwal changed the title ~~feat: Implement a Single Round Fraudproof as a minimal integration test~~ feat: Test switching between a cosmos-sdk baseapp and fraudproof Aug 8, 2022

Manav-Aggarwal linked an issue Aug 8, 2022 that may be closed by this pull request

Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #252

Closed

Manav-Aggarwal removed a link to an issue Aug 8, 2022

Implement a Single Round Fraudproof as a minimal integration test #245

Closed

5 tasks

liamsi reviewed Aug 9, 2022

View reviewed changes

baseapp/baseapp_test.go Outdated Show resolved Hide resolved

liamsi reviewed Aug 9, 2022

View reviewed changes

baseapp/baseapp_test.go Show resolved Hide resolved

Manav-Aggarwal added 23 commits August 16, 2022 15:58

Add correct baseapp usage

ec5598a

Finish writing setSubstoreKVPair option

55ac0c6

Change setSubstoreKVPair appOption to ordered app option

4905e62

Create separate routerOpts for fraudproof baseapp init

f135c69

Compare smt roots instead of commit hashes

5f18584

Add note about using SMT root

e1e56cd

Refactor generate fraudProof code

ed75c1c

Move generate fraudProof to baseapp

a0d4b61

Update function header

406ca9d

Revert "Remove rocksdb for now because mac library issues locally, ca…

babc547

…n revert back when merging" This reverts commit 011f9d1.

Remove uncommented lines

6659093

Tidy up code

7e5ac2a

fix naming capitalization

f59bed5

Remove unused v from options

31e5b5e

Export non-exported errors

bc887b7

Remove commit calls in prototype and update test function doc

5626ebd

Refactor code to clarify order

d1e4b8b

Fix loadFromFraudProof issue

e2199e8

Add more checks comparing states

5dfd83b

Wrap GetSMTProof with Must

73bc9af

Address Josh comments

c6683f0

Add some comments

94eeb93

Export fraudproof after S2 now

c088b81

Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from 266a4de to c088b81 Compare August 16, 2022 19:58

Manav-Aggarwal closed this Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #248

feat: Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #248

Manav-Aggarwal commented Aug 3, 2022 •

edited

Loading

liamsi Aug 5, 2022

Manav-Aggarwal Aug 5, 2022

liamsi Aug 5, 2022

Manav-Aggarwal Aug 5, 2022

adlerjohn Aug 7, 2022

liamsi Aug 5, 2022

Manav-Aggarwal Aug 5, 2022

liamsi Aug 5, 2022

liamsi left a comment

adlerjohn Aug 7, 2022

Manav-Aggarwal Aug 8, 2022

Manav-Aggarwal commented Nov 7, 2022

		traceListenMixin: newTraceListenMixin(),
		substoreTraceListenMixins: make(map[types.StoreKey]*traceListenMixin),

feat: Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #248

feat: Test stateless execution for cosmos-sdk baseapp using SMT-based fraudproofs #248

Conversation

Manav-Aggarwal commented Aug 3, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamsi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Manav-Aggarwal commented Nov 7, 2022

Manav-Aggarwal commented Aug 3, 2022 •

edited

Loading